Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump sor to 4.18.2 - fix: support mixed quote on rest of L2s #831

Merged
merged 2 commits into from
Feb 20, 2025

Conversation

jsy1218
Copy link
Member

@jsy1218 jsy1218 commented Feb 20, 2025

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    fix

  • What is the current behavior? (You can also link to an open issue here)
    we don't support mixed quote on arb, polygon, bnb, zora, worldchain, avax, op

  • What is the new behavior (if this is a feature change)?
    we support mixed quote on arb, polygon, bnb, zora, worldchain, avax, op

  • Other information:

Copy link
Member Author

jsy1218 commented Feb 20, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jsy1218 jsy1218 marked this pull request as ready for review February 20, 2025 23:33
@jsy1218 jsy1218 requested a review from a team as a code owner February 20, 2025 23:33
@graphite-app graphite-app bot requested review from xrsv and cgkol February 20, 2025 23:34
Copy link

graphite-app bot commented Feb 20, 2025

Graphite Automations

"Request reviewers once CI passes on smart-order-router repo" took an action on this PR • (02/20/25)

3 reviewers were added and 1 assignee was added to this PR based on Siyu Jiang (See-You John)'s automation.

Copy link
Member Author

jsy1218 commented Feb 20, 2025

Merge activity

  • Feb 20, 6:50 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Feb 20, 6:50 PM EST: A user merged this pull request with Graphite.

@jsy1218 jsy1218 merged commit fa6fe83 into main Feb 20, 2025
29 of 30 checks passed
@jsy1218 jsy1218 deleted the siyujiang/sor-4.18.2-mixed-quote-l2s branch February 20, 2025 23:50
jsy1218 added a commit to Uniswap/routing-api that referenced this pull request Feb 21, 2025
…1022)

Release Uniswap/smart-order-router#831

alll L2 tests passed https://app.warp.dev/block/Q43sdmGDmSdE8SKuB3Eh1m, L1 tests failure cannot be due to this change, because it does not touch any L1 logic at all.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants